CoW: Fix warnings for eval #56170
Merged
CoW: Fix warnings for eval #56170
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pandas/core/generic.py
Outdated
| clean_column_name(k): Series( | ||
| v._values, copy=False, index=v.index | ||
| ).__finalize__(v) | ||
| for k, v in self.items() |
There was a problem hiding this comment.
Maybe you can use _iter_column_arrays here instead of items() to avoid going through Series construction twice?
There was a problem hiding this comment.
With my suggestion, the column name was lost. Hopefully the last commit should fix that
jorisvandenbossche
approved these changes
Dec 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an option if eval can't do inplace on numpy under the hood
xref #56019