-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Index.str.cat casting result always to object #56157
Conversation
@@ -689,12 +690,15 @@ def cat( | |||
out: Index | Series | |||
if isinstance(self._orig, ABCIndex): | |||
# add dtype for case that result is all-NA | |||
dtype = None | |||
if isna(result).all(): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Does the comment in test_str_cat_all_na
refer to the the object dtype here (othewise good to add a TODO comment here)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes that's the place where I found this being an issue
cc @mroeschke |
Thanks @phofl |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.