BUG fixes for date_range boundaries

[jrmylow]

• closes BUG: date_range(freq='Y') is missing a date #56134
• closes BUG: Negative freq in date_range produces values out of start and endpoints #56147
• Tests added and passed if fixing a bug or adding a new feature
• All code checks passed.
• Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

Fix for two issues with date_range where:

• A valid timestamp in range would be accidentally dropped when using year end and the starting timestamp was not midnight (56134)
• A negative year end offset and start increment at a date earlier than year end would include the year end of the starting date (despite being out of bounds of start and end)

[jrmylow]

pre-commit.ci autofix

[github-actions]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

[jrmylow]

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

updated and still pending review

[MarcoGorelli]

sorry for the delay, will try to get to it this week or next

[MarcoGorelli]

Nice work! Sorry this has taken me a while

First, can we move this to the 2.3.0 whatsnew note please?

Second, is it possible to fix the two bugs independently?
As in, I think you can just remove the

    elif end and not offset.is_on_offset(end):
        # Incompatible types in assignment (expression has type "datetime",
        # variable has type "Optional[Timestamp]")
        end = offset.rollback(end)  # type: ignore[assignment]

completely, and all existing tests will pass, as well the snippet from 56134?

If so, I'd suggest splitting this - first, remove the unnecessary elif end block, and then we fix the if start and not ... one separately

[jrmylow]

ok then I'll close this, this has been picked up separately in:

• BUG fix for date_range 56134 #56831 for BUG: date_range(freq='Y') is missing a date #56134
• BUG: Negative freq in date_range produces values out of start and endpoints #56832 for BUG: Negative freq in date_range produces values out of start and endpoints #56147

Thanks