-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
TST: add test to verify if SystemExit is raised correctly. #56145
Merged
rhshadrach
merged 14 commits into
pandas-dev:main
from
HaruguchiKazuto:shiny-new-feature
Nov 29, 2023
Merged
TST: add test to verify if SystemExit is raised correctly. #56145
rhshadrach
merged 14 commits into
pandas-dev:main
from
HaruguchiKazuto:shiny-new-feature
Nov 29, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
HaruguchiKazuto
commented
Nov 24, 2023
•
edited
Loading
edited
- closes Groupby doesn't call aggregation on empty groups #18869
- Tests added and passed if fixing a bug or adding a new feature
- All code checks passed.
rhshadrach
added
Groupby
Needs Tests
Unit test(s) needed to prevent regressions
Categorical
Categorical Data Type
labels
Nov 24, 2023
HaruguchiKazuto
force-pushed
the
shiny-new-feature
branch
from
November 26, 2023 11:46
5626043
to
26b8ee7
Compare
rhshadrach
approved these changes
Nov 29, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
Thanks @HaruguchiKazuto! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.