ENH: non-nano datetime64s for read_sas #56127
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
IO SAS
mroeschke
reviewed
Nov 30, 2023
doc/source/whatsnew/v2.2.0.rst
Outdated
| @@ -188,6 +188,7 @@ Other enhancements | |||
| - :meth:`to_sql` with method parameter set to ``multi`` works with Oracle on the backend | |||
| - :attr:`Series.attrs` / :attr:`DataFrame.attrs` now uses a deepcopy for propagating ``attrs`` (:issue:`54134`). | |||
| - :func:`read_csv` now supports ``on_bad_lines`` parameter with ``engine="pyarrow"``. (:issue:`54480`) | |||
| - :func:`read_sas` returns ``datetime64`` dtypes with resolutions better matching those stored natively in SAS, and avoids returning object-dtype in cases that cannot be help with ``datetime64[ns]`` dtype (:issue:`56127`) | |||
There was a problem hiding this comment.
Suggested change
| - :func:`read_sas` returns ``datetime64`` dtypes with resolutions better matching those stored natively in SAS, and avoids returning object-dtype in cases that cannot be help with ``datetime64[ns]`` dtype (:issue:`56127`) | |
| - :func:`read_sas` returns ``datetime64`` dtypes with resolutions better matching those stored natively in SAS, and avoids returning object-dtype in cases that cannot be stored with ``datetime64[ns]`` dtype (:issue:`56127`) |
?
mroeschke
reviewed
Nov 30, 2023
| @@ -62,6 +58,10 @@ | |||
| ) | |||
|
|
|||
|
|
|||
| _unix_origin = Timestamp("1970-01-01") | |||
There was a problem hiding this comment.
Will these be reused in the future? Otherwise could just inline the 10 year timedelta in _convert_datetimes
There was a problem hiding this comment.
either way. i think this is nicely clear about where the 10 year difference stems from (also cant do Timedelta(years=10))
mroeschke
approved these changes
Dec 5, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Pre-empts a bunch of the remaining test failures in #55901.
cc @ChadFulton for help determing what the correct "expected"s should be.