Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TST: Clean pytest fixtures #56088

Merged
merged 8 commits into from
Nov 21, 2023
Merged

TST: Clean pytest fixtures #56088

merged 8 commits into from
Nov 21, 2023

Conversation

mroeschke
Copy link
Member

  • Move sparsely used fixtures to where they are used (in the file or inlined)
  • Removed fixtures that had no use in conftest.py files

@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Nov 20, 2023
jbrockmendel
jbrockmendel reviewed Nov 20, 2023
View reviewed changes
pandas/tests/io/excel/test_writers.py Outdated

@pytest.fixture
def tsframe():
return tm.makeTimeDataFrame()[:5]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

OK for this to be out of scope, but let's just inline this

@jbrockmendel
Copy link
Member

if you're on fixture patrol, we have a couple of

pytestmark = pytest.mark.parametrize("ext", [".ods"])
pytestmark = pytest.mark.parametrize("ext", [".xlsx"])

that look pretty clearly wrong (not

@mroeschke mroeschke added this to the 2.2 milestone Nov 20, 2023
@mroeschke mroeschke merged commit bf64de5 into pandas-dev:main Nov 21, 2023
40 checks passed
@mroeschke mroeschke deleted the tst/cln/fixtures branch November 21, 2023 19:46
phofl pushed a commit to phofl/pandas that referenced this pull request Nov 21, 2023
@mroeschke @phofl
TST: Clean pytest fixtures (pandas-dev#56088)
aabf219 
* TST: Clean/moved unused/sparsely use fixtures

* Refactor xml_data_path

* More fixture fixes

* inline tsframe

* Simplify ext fixtures
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jbrockmendel jbrockmendel jbrockmendel left review comments

Assignees
No one assigned
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@mroeschke @jbrockmendel