Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Reduce Cyclomatic Complexity in sort_values() #56078

Closed
wants to merge 1 commit into from

Conversation

victorm44
Copy link

Descripción del Pull Request

Cambios Realizados:
Realicé una refactorización en la función sort_values() para reducir la complejidad ciclomática y mejorar la legibilidad del código.

Detalles Adicionales:

  • Simplifiqué la lógica utilizando operadores ternarios.
  • Eliminé redundancias en la estructura del código.
  • Esta refactorización no introduce cambios en la funcionalidad existente.

Resultados Esperados:
La finalidad de esta mejora es facilitar la comprensión y el mantenimiento del código en la función sort_values(). No se espera que cause problemas adicionales y se mantiene la funcionalidad actual.

@mroeschke
Copy link
Member

Thanks for the PR, but it's not clear to me that these changes are more beneficial and additionally tests are failing. Going to close, but it's advisable to first open an issue to describe the issue you are trying to solve here and get buy-in from a core dev before proceeding.

@mroeschke mroeschke closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants