Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PERF: Reduce Cyclomatic Complexity in _rename() #56076

Closed

Conversation

camilotabago05
Copy link

Modularized the _rename() function to improve readability and reduce cyclomatic
complexity. Extracted code blocks into helper functions, making the code more
understandable and maintaining the original structure.

@mroeschke
Copy link
Member

Thanks for the PR, but it's not clear to me that these changes are more beneficial and additionally tests are failing. Going to close, but it's advisable to first open an issue to describe the issue you are trying to solve here and get buy-in from a core dev before proceeding.

@mroeschke mroeschke closed this Nov 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants