Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adjust Index specific tests for string option #56074

Merged
merged 48 commits into from
Dec 9, 2023
Merged

Adjust Index specific tests for string option #56074

merged 48 commits into from
Dec 9, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 20, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

there are a couple of pre-cursors still open

phofl and others added 30 commits October 22, 2023 23:33
@phofl
BUG: setitem casting object Index to arrow strings
6accf2b
@phofl
Fix
61f4903
@phofl
Start fixing index tests
2effd1f
@phofl
BUG: Index.isin raising for arrow strings and null set
6569663
@phofl
Merge branch '55821' into tests
382b989
@phofl
Fix more tests
cdbdba2
@phofl
TST: Fix shares_memory for arrow string dtype
57cb8f4
@phofl
TST: Fix shares_memory for arrow string dtype
7697059
@phofl
TST: Fix shares_memory for arrow string dtype
285f7bb
@phofl
Merge branch 'tm_shares' into tests
4afaf69
@phofl
Fix more tests
f59c4bc
@phofl
BUG: Index.getitem returning wrong result with negative step for arrow
ff6e271
@phofl
Merge branch 'main' into indexing_negative_steps
7518250
@phofl
Update
7684911
@phofl
Update
7474cb2
@phofl
Merge branch 'indexing_negative_steps' into tests
22767d2 
# Conflicts:
#	doc/source/whatsnew/v2.1.3.rst
#	pandas/tests/indexes/object/test_indexing.py
@phofl
Fix
b27b0f8
@phofl
Merge branch 'indexing_negative_steps' into tests
2f3f6ce
@phofl
Update array.py
659577e
@phofl
Fix
11c0e86
@phofl
Merge branch 'main' into indexing_negative_steps
30097eb
@phofl
Merge branch 'main' into setitem_index_inference_string_dtype
717c306
@phofl
Move
f55b62f
@phofl
Move
ea3fcfb
@phofl
Merge remote-tracking branch 'upstream/main' into indexing_negative_s…
5c4bc50 
…teps
@phofl
Fix
86fe4f1
@phofl
Merge branch 'main' into setitem_index_inference_string_dtype
19b4613
@phofl
Add gh ref
2425529
@phofl
Update v2.1.4.rst
84e815e
@phofl
Merge remote-tracking branch 'upstream/main' into tests
0edead5 
# Conflicts:
#	pandas/_testing/__init__.py
@phofl phofl requested a review from mroeschke November 22, 2023 01:00
@mroeschke mroeschke added Strings String extension data type and string data Index Related to the Index class or subclasses Arrow pyarrow functionality labels Nov 22, 2023
@mroeschke mroeschke added this to the 2.2 milestone Dec 9, 2023
@mroeschke mroeschke merged commit 91ddc8b into pandas-dev:main Dec 9, 2023
44 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the tests branch December 9, 2023 19:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Arrow pyarrow functionality Index Related to the Index class or subclasses Strings String extension data type and string data
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@phofl @mroeschke