CoW: Add warning for mask, where and clip with inplace #56067
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Warnings
14 tasks
| @@ -1550,6 +1551,23 @@ def test_chained_where_mask(using_copy_on_write, func): | |||
| with tm.raises_chained_assignment_error(): | |||
| getattr(df[["a"]], func)(df["a"] > 2, 5, inplace=True) | |||
| tm.assert_frame_equal(df, df_orig) | |||
| else: | |||
| with tm.assert_produces_warning( | |||
| FutureWarning, match="inplace method", check_stacklevel=False | |||
There was a problem hiding this comment.
Why is the check_stacklevel=False needed here? (the warnings are added to top-level methods, and we are testing those directly, so that should be a simple case?)
There was a problem hiding this comment.
I have no clue, this showed up in a ci build only and only on one, didn't want to spend more time debugging this...
But can try to reproduce locally if you want
There was a problem hiding this comment.
Ah, that's just because mask is calling where under the hood. So it was actually raising the warning twice (once with correct and once with incorrect stacklevel).
Pushing a fix to let it only warn once.
There was a problem hiding this comment.
Ah interesting
Not clue why this didn't fail locally though
Co-authored-by: Joris Van den Bossche <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
xref #56019