PERF: Improve conversion in read_csv when string option is set #56046
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can we get this one in? |
mroeschke
reviewed
Nov 30, 2023
| frame = table.to_pandas(types_mapper=arrow_string_types_mapper()) | ||
|
|
||
| def types_mapper(dtype): | ||
| dtype_dict = self.kwds["dtype"] |
There was a problem hiding this comment.
Is dtype guaranteed to be in self.kwds at this point?
mroeschke
approved these changes
Nov 30, 2023
|
Thanks @phofl |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.cc @jbrockmendel
The finalise does the conversion, but this might make us roundtrip