DEPR: fractional periods in date_range, timedelta_range, period_range… #56036
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 19, 2023
doc/source/whatsnew/v2.2.0.rst
Outdated
| @@ -266,6 +266,7 @@ Other Deprecations | |||
| - Deprecated :meth:`.DataFrameGroupBy.fillna` and :meth:`.SeriesGroupBy.fillna`; use :meth:`.DataFrameGroupBy.ffill`, :meth:`.DataFrameGroupBy.bfill` for forward and backward filling or :meth:`.DataFrame.fillna` to fill with a single value (or the Series equivalents) (:issue:`55718`) | |||
| - Deprecated :meth:`Index.format`, use ``index.astype(str)`` or ``index.map(formatter)`` instead (:issue:`55413`) | |||
| - Deprecated ``year``, ``month``, ``quarter``, ``day``, ``hour``, ``minute``, and ``second`` keywords in the :class:`PeriodIndex` constructor, use :meth:`PeriodIndex.from_fields` instead (:issue:`55960`) | |||
| - Deprecated allowing fractional ``periods`` argument in :func:`date_range`, :func:`timedelta_range`, :func:`period_range`, and :func:`interval_range` (:issue:`56036`) | |||
There was a problem hiding this comment.
Should we specify float instead of fractional since e.g periods=2.0 would be disallowed as well?
There was a problem hiding this comment.
This only deprecated allowing non-round floats. id be OK with deprecating round ones too
There was a problem hiding this comment.
Yeah let's just deprecate all floats and require periods to be integer in the future
mroeschke
approved these changes
Nov 20, 2023
|
Thanks @jbrockmendel |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 21, 2023
pandas-dev#56036) * DEPR: fractional periods in date_range, timedelta_range, period_range, interval_range * GH ref * DEPR: non-integer periods
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…, interval_range
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.