Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DOC: Fix GH# in whatsnew not for DataFrameGroupBy.value_counts bugfix #56031

Merged
merged 2 commits into from
Nov 18, 2023
Merged

DOC: Fix GH# in whatsnew not for DataFrameGroupBy.value_counts bugfix #56031

merged 2 commits into from
Nov 18, 2023

Conversation

rhshadrach
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

I had the wrong GH# in #56016 in the whatsnew and the code; the GH# added to the tests was correct.

@mroeschke mroeschke added this to the 2.2 milestone Nov 18, 2023
@mroeschke mroeschke merged commit 517973e into pandas-dev:main Nov 18, 2023
41 of 44 checks passed
@mroeschke
Copy link
Member

Thanks @rhshadrach

@rhshadrach rhshadrach deleted the fix_pr_number branch November 18, 2023 01:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Docs
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
2 participants
@rhshadrach @mroeschke