TST: Simplify and clarify test skipping #56027
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Testing
| @@ -80,7 +80,7 @@ def test_setting_backend_without_plot_raises(monkeypatch): | |||
| assert pandas.options.plotting.backend == "matplotlib" | |||
|
|
|||
|
|
|||
| @td.skip_if_mpl | |||
| @td.skip_if_installed("matplotlib") | |||
There was a problem hiding this comment.
is there any perf impact of evaluating these once vs in a bunch of places?
There was a problem hiding this comment.
Very slight. e.g. when running test_eval.py with skip_if_no_ne replaced locally I'm getting a runtime of 26.86s on this PR vs 26.69s on main. IMO I think this timing difference is OK given the cleanup
|
One question, otherwise LGTM |
mroeschke
commented
Nov 17, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.