Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

REF: use conditional-nogil in libalgos #56025

Merged
merged 1 commit into from
Nov 17, 2023
Merged

REF: use conditional-nogil in libalgos #56025

merged 1 commit into from
Nov 17, 2023

Conversation

jbrockmendel
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke mroeschke added the Internals Related to non-user accessible pandas implementation label Nov 17, 2023
WillAyd
WillAyd approved these changes Nov 17, 2023
View reviewed changes
Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

very nice

@mroeschke mroeschke added this to the 2.2 milestone Nov 17, 2023
@mroeschke mroeschke merged commit fc0164c into pandas-dev:main Nov 17, 2023
44 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-nogil branch November 17, 2023 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@WillAyd WillAyd WillAyd approved these changes

Assignees
No one assigned
Labels
Internals Related to non-user accessible pandas implementation
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
3 participants
@jbrockmendel @mroeschke @WillAyd