BUG: pivot_table with margins and numeric columns #55933
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 13, 2023
mroeschke
reviewed
Nov 14, 2023
| # GH#26568. Use names instead of indices in case of numeric names | ||
| new_order_indices = [len(cols)] + list(range(len(cols))) | ||
| new_order_names = [row_margin.index.names[i] for i in new_order_indices] | ||
| row_margin.index = row_margin.index.reorder_levels(new_order_names) |
There was a problem hiding this comment.
Are row_margin.index.names guaranteed to be unique?
There was a problem hiding this comment.
In this case, row_margin.index.names are the names of the columns in the original df. They should be unique. If user try to pivot_table on a df with duplicated column names, upstream code would scream first.
There was a problem hiding this comment.
Thanks for the explanation. Could you resolve the merge conflict otherwise looks good.
mroeschke
approved these changes
Nov 20, 2023
|
Thanks @quangngd |
phofl
pushed a commit
to phofl/pandas
that referenced
this pull request
Nov 21, 2023
* fix and add test * add whatsnew * rm comment
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.