Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added str to index_col attribute in the read_excel function description #55857

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Added str to index_col attribute in the read_excel function description #55857

merged 1 commit into from
Nov 7, 2023

Conversation

shyamala-venkat
Copy link
Contributor

@shyamala-venkat shyamala-venkat commented Nov 7, 2023 •
edited by rhshadrach
Loading

@rhshadrach rhshadrach added IO Excel read_excel, to_excel Typing type annotations, mypy/pyright type checking labels Nov 7, 2023
@rhshadrach
Copy link
Member

@shyamala-venkat - thanks for the PR, I edited your OP above so that the issue reads #55843. By including the #, GitHub links to the issue and it will automatically be closed when this PR is merged.

@rhshadrach rhshadrach added this to the 2.2 milestone Nov 7, 2023
rhshadrach
rhshadrach approved these changes Nov 7, 2023
View reviewed changes
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, this is already tested in test_index_col_str and the docstring also already includes str.

@mroeschke mroeschke merged commit 4377dd1 into pandas-dev:main Nov 7, 2023
34 of 42 checks passed
@mroeschke
Copy link
Member

Thanks @shyamala-venkat

@mroeschke mroeschke mentioned this pull request Nov 7, 2023
Closed
@shyamala-venkat
Copy link
Contributor Author

Thank you @rhshadrach for approving the pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhshadrach rhshadrach rhshadrach approved these changes

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
IO Excel read_excel, to_excel Typing type annotations, mypy/pyright type checking
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

Internal read_excel() typing for index_col is incorrect
3 participants
@shyamala-venkat @rhshadrach @mroeschke