Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: Fix shares_memory for arrow string dtype #55823

Merged
merged 4 commits into from
Nov 6, 2023

Conversation

phofl
Copy link
Member

@phofl phofl commented Nov 4, 2023

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

@mroeschke
Copy link
Member

mypy.....................................................................Failed
- hook id: mypy
- duration: 131.55s
- exit code: 1

pandas/_testing/__init__.py:1051: error: "ExtensionDtype" has no attribute "storage"  [attr-defined]
pandas/_testing/__init__.py:1058: error: "ExtensionDtype" has no attribute "storage"  [attr-defined]
Found 2 errors in 1 file (checked 1445 source files)

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Strings String extension data type and string data Arrow pyarrow functionality labels Nov 4, 2023
@phofl
Copy link
Member Author

phofl commented Nov 5, 2023

thx

@mroeschke mroeschke added this to the 2.2 milestone Nov 6, 2023
@mroeschke mroeschke merged commit 95c2a7d into pandas-dev:main Nov 6, 2023
33 of 34 checks passed
@mroeschke
Copy link
Member

Thanks @phofl

@phofl phofl deleted the tm_shares branch November 6, 2023 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Arrow pyarrow functionality Strings String extension data type and string data Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants