Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BUG: assert_extension_array_equal using the wrong dtype #55812

Merged
merged 5 commits into from
Nov 6, 2023
Merged

BUG: assert_extension_array_equal using the wrong dtype #55812

merged 5 commits into from
Nov 6, 2023

Conversation

rob-sil
Copy link
Contributor

@rob-sil rob-sil commented Nov 3, 2023

mroeschke
mroeschke reviewed Nov 3, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you add a test?

@mroeschke mroeschke added Testing pandas testing functions or related to the test suite Non-Nano datetime64/timedelta64 with non-nanosecond resolution labels Nov 3, 2023
@mroeschke mroeschke added this to the 2.2 milestone Nov 6, 2023
@mroeschke mroeschke merged commit b6f2909 into pandas-dev:main Nov 6, 2023
26 of 34 checks passed
@mroeschke
Copy link
Member

Thanks @rob-sil

@christophebedard christophebedard mentioned this pull request Apr 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Non-Nano datetime64/timedelta64 with non-nanosecond resolution Testing pandas testing functions or related to the test suite
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.

BUG: assert_frame_equal fails with AttributeError: 'numpy.dtype[datetime64]' object has no attribute 'unit'
2 participants
@rob-sil @mroeschke