Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added code for QuarterBegin class to handle the "_period_dtype_code" attribute #55809

Closed
wants to merge 1 commit into from
Closed

Added code for QuarterBegin class to handle the "_period_dtype_code" attribute #55809

wants to merge 1 commit into from

Conversation

Dhayanidhi-M
Copy link

No description provided.

mroeschke
mroeschke requested changes Nov 3, 2023
View reviewed changes
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give more context for this change? e.g. an open Github issue

@MarcoGorelli
Copy link
Member

thanks for your PR but I think this should raise, QuarterEnd is already used to create Periods, and Periods don't distinguish between "start" and "end" anyway. It's an implementation detail which freq is used under the hood, the user would just pass period='Q'

closing then, but thanks for your PR!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke requested changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Dhayanidhi-M @MarcoGorelli @mroeschke