ENH/BUG: infer reso in array_strptime #55805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Nov 3, 2023
| tolerance = np.timedelta64(1, "ms") | ||
|
|
||
| assert res.dtype == "M8[us]" | ||
| assert abs(res[0] - now) < tolerance |
There was a problem hiding this comment.
I would be OK skipping the comparison to a separate "now" to potentially avoid near-miss occasional failures. I think at least passing "today" and "now" through array_strptime and seeing if us is return is good enough
There was a problem hiding this comment.
would you be happier with a bigger tolerance? I can imagine regressions here that cause this to miss by a huge amount, hard to imagine regressions that miss by a small amount
There was a problem hiding this comment.
Yeah a larger tolerance would give me more peace.
mroeschke
added
the
Non-Nano
mroeschke
approved these changes
Nov 3, 2023
|
Thanks @jbrockmendel |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.