-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: _validate_setitem_value fails to raise for PandasArray #55759
Conversation
If we make Index false then we will get same hash
Added _validate_setitem_Value
@hvsesha thanks you for the work with this bug. I prefer to close this PR, as you have many changes that we don't want to merge here, including breaking the PEP-8 styles, adding files with your tests, changing default arguments of existing functions... I see it's your first contribution, what I suggest is the same:
You can ping me at any point of this if you need help. I think doing things step by step will make things easier both for you, and for reviewers. Also, you shouldn't open PRs directly from the |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.