Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: _validate_setitem_value fails to raise for PandasArray #55759

Closed
wants to merge 18 commits into from

Conversation

hvsesha
Copy link

@hvsesha hvsesha commented Oct 30, 2023

@hvsesha hvsesha requested a review from MarcoGorelli as a code owner November 3, 2023 06:34
@datapythonista datapythonista changed the title Issue # 51044 BUG: _validate_setitem_value fails to raise for PandasArray Nov 17, 2023
@datapythonista
Copy link
Member

@hvsesha thanks you for the work with this bug. I prefer to close this PR, as you have many changes that we don't want to merge here, including breaking the PEP-8 styles, adding files with your tests, changing default arguments of existing functions...

I see it's your first contribution, what I suggest is the same:

  • You look in our code base where the tests for the function with the bug are
  • You add a new test that catches the error
  • You open a PR with the new test
  • The test will fail, and the CI will be green
  • Once we reached this milestone, you implement a fix for the bug, without adding new files, or modifying the signature of existing functions unless strictly required

You can ping me at any point of this if you need help. I think doing things step by step will make things easier both for you, and for reviewers.

Also, you shouldn't open PRs directly from the main branch, you should create a new branch specific to this PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: _validate_setitem_value fails to raise for PandasArray
2 participants