Update _core.py to show valid plot types in the Error Message for Invalid plot kind #55758
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…alid Plots
If an invalid plot type is passed, the error message raised is
```
raise ValueError(f"{kind} is not a valid plot kind")
```
To give more context to user, it should also show the valid plot kinds.
mroeschke
reviewed
Oct 30, 2023
pandas/plotting/_core.py
Outdated
| @@ -961,7 +961,7 @@ def __call__(self, *args, **kwargs): | |||
| return plot_backend.plot(self._parent, x=x, y=y, kind=kind, **kwargs) | |||
|
|
|||
| if kind not in self._all_kinds: | |||
| raise ValueError(f"{kind} is not a valid plot kind") | |||
| raise ValueError(f"{kind} is not a valid plot kind\nValid plot kinds {self._all_kinds}") | |||
There was a problem hiding this comment.
Can you just add a new line in the file instead of \n?
There was a problem hiding this comment.
raise ValueError(f"""{kind} is not a valid plot kind
Valid plot kinds {self._all_kinds}""")
Like this? Otherwise it will raise value error and will not go on next line. Maybe I can completely remove \n
There was a problem hiding this comment.
You can check out examples in the repo where there are multi-line exception messages.
mroeschke
added
Visualization
|
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
mroeschke
approved these changes
Oct 31, 2023
|
Thanks @ahmadmustafaanis |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If an invalid plot type is passed, the error message raised is
To give more context to user, it should also show the valid plot kinds.