BUG: incorrect OutOfBoundsDatetime with non-nano dtype #55756
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 30, 2023
| dtype = "M8[us]" | ||
| # NB: the 2500 is interpreted as nanoseconds and rounded *down* | ||
| # to 2 microseconds | ||
| vals = [ts, "2999-01-02 03:04:05.678910", 2500] |
There was a problem hiding this comment.
Could we add a doc example/explanation for this edge case (maybe in to_datetime)?
There was a problem hiding this comment.
to_datetime isn't a great fit bc it doesnt have a dtype keyword. ill have to give some thought to where this might live. would you be OK with punting on that for the moment? this is a blocker for resolution-inference
There was a problem hiding this comment.
OK to punt for now. I do think this is a potential non-obvious behavior that users might encounter so would be good to document in the future
mroeschke
added
Bug
Non-Nano
mroeschke
approved these changes
Oct 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.Big step toward #55564. tznaive analogue to #54620