REF: Avoid np.can_cast for scalar inference for NEP 50 #55707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
added
the
Compat
lithomas1
reviewed
Oct 26, 2023
pandas/core/dtypes/cast.py
Outdated
| @@ -699,7 +699,9 @@ def _maybe_promote(dtype: np.dtype, fill_value=np.nan): | |||
| dtype = np.dtype(np.object_) | |||
|
|
|||
| elif issubclass(dtype.type, np.integer): | |||
| if not np.can_cast(fill_value, dtype): | |||
| try: | |||
| np_can_hold_element(dtype, fill_value) | |||
There was a problem hiding this comment.
Maybe we should right a wrapper function for this to make our own can cast.
Then, we don't have to scatter try/catch's everywhere.
There was a problem hiding this comment.
Good idea. Wrapped in a helper function
3 tasks
|
Looks like the test failures are timeouts hopefully unrelated to this change. Going to backport this change as this could be useful for 2.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 27, 2023
…ence for NEP 50
|
Thank you! When do you plan to push out a new dev wheel with this patch? 🙏 |
|
Wheels uploads run nightly at 3:27 UTC, so hopefully the dev wheels should be available tomorrow |
|
I can confirm the dev wheel is up and it works now. Thanks again! |
mroeschke
added a commit
that referenced
this pull request
Oct 27, 2023
… inference for NEP 50) (#55716) Backport PR #55707: REF: Avoid np.can_cast for scalar inference for NEP 50 Co-authored-by: Matthew Roeschke <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like using
np.can_castfor scalar casting inference is deprecated. We should probably use our own scalar casting inference routines instead