Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: add missing assert in test_apply_datetimetz in test_series_apply.py #55700

Merged
merged 1 commit into from
Oct 26, 2023

Conversation

yuanx749
Copy link
Contributor

I think assert is missing before result == "Asia/Tokyo". Came across this when checking some Pylance warnings.

result = s.apply(f, by_row=by_row)
if by_row:
exp = Series(["Asia/Tokyo"] * 25, name="XX")
tm.assert_series_equal(result, exp)
else:
result == "Asia/Tokyo"

@MarcoGorelli MarcoGorelli added the Testing pandas testing functions or related to the test suite label Oct 26, 2023
@MarcoGorelli MarcoGorelli added this to the 2.2 milestone Oct 26, 2023
Copy link
Member

@MarcoGorelli MarcoGorelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice spot, thanks @yuanx749

@MarcoGorelli MarcoGorelli merged commit d7b9443 into pandas-dev:main Oct 26, 2023
34 of 37 checks passed
@yuanx749 yuanx749 deleted the missing-assert branch October 26, 2023 15:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants