This fix allows a DataFrame to retain key order from a dictionary #55696
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulreece
force-pushed
the
single_column_order_from_dict
branch
4 times, most recently
from
293d478 to
f605da2
Compare
mroeschke
reviewed
Oct 27, 2023
doc/source/whatsnew/v2.2.0.rst
Outdated
| @@ -327,7 +327,7 @@ Datetimelike | |||
| - Bug in addition or subtraction of :class:`BusinessDay` offset with ``offset`` attribute to non-nanosecond :class:`Index`, :class:`Series`, or :class:`DataFrame` column giving incorrect results (:issue:`55608`) | |||
| - Bug in addition or subtraction of :class:`DateOffset` objects with microsecond components to ``datetime64`` :class:`Index`, :class:`Series`, or :class:`DataFrame` columns with non-nanosecond resolution (:issue:`55595`) | |||
| - Bug in addition or subtraction of very large :class:`Tick` objects with :class:`Timestamp` or :class:`Timedelta` objects raising ``OverflowError`` instead of ``OutOfBoundsTimedelta`` (:issue:`55503`) | |||
| - | |||
| - Bug in creating a Dataframe using the from_dict method which would alphabetize the rows of the created DataFrame. (:issue:`55683`) | |||
There was a problem hiding this comment.
Suggested change
| - Bug in creating a Dataframe using the from_dict method which would alphabetize the rows of the created DataFrame. (:issue:`55683`) | |
| - Bug in :meth:`Dataframe.from_dict` which would always sort the rows of the created :class:`DataFrame`. (:issue:`55683`) |
mroeschke
reviewed
Oct 27, 2023
| @@ -53,10 +53,10 @@ def test_rename(self, float_frame): | |||
| # gets sorted alphabetical | |||
There was a problem hiding this comment.
Just fixed both of these! Thanks for taking a look.
paulreece
force-pushed
the
single_column_order_from_dict
branch
2 times, most recently
from
1f85072 to
9dc4a63
Compare
paulreece
force-pushed
the
single_column_order_from_dict
branch
from
9dc4a63 to
074ab2f
Compare
…h only one column instead of sorting them alphabetically.
|
Not sure why this Closed. |
mroeschke
approved these changes
Oct 30, 2023
|
Thanks @paulreece |
Closed
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fix allows a DataFrame to retain key order from a dictionary with only one column instead of sorting them alphabetically.
Note: I had to change the order for the rename tests in
test_rename.pybut the order there seemed trivial. If I'm wrong in my assumption please let me know. I also had to change the index order of the control df inindexing/multiindex/test_setitem.pybut again this seemed trivial/innocuous change in this circumstance.doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.