BUG: Groupby not keeping object dtype when infer string is set #55620
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
phofl
added
Strings
rhshadrach
reviewed
Oct 22, 2023
| @@ -1904,8 +1904,7 @@ def _agg_py_fallback( | |||
| ser = Series(values, copy=False) | |||
| else: | |||
| # We only get here with values.dtype == object | |||
| # TODO: special case not needed with ArrayManager | |||
| df = DataFrame(values.T) | |||
| df = DataFrame(values.T, dtype=values.dtype) | |||
There was a problem hiding this comment.
Perhaps slightly out of scope, but I think it'd be good to add an assert on values.dtype == object here
There was a problem hiding this comment.
Yeah I'd rather keep this out of here
rhshadrach
added
Groupby
Dtype Conversions
|
Is this a regression with no related issue? |
|
I am working on a build that uses arrow backed strings by default, but this turns up dozens of bugs related to either the new string dtype we added for 2.1 or arrow strings more generally, not opening issues since I am fixing them when I come across them |
|
Thanks @phofl |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 22, 2023
…hen infer string is set
mroeschke
pushed a commit
that referenced
this pull request
Oct 22, 2023
…type when infer string is set) (#55629) Backport PR #55620: BUG: Groupby not keeping object dtype when infer string is set Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.