Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

TST: move misplaced tests #55603

Merged
merged 6 commits into from
Oct 20, 2023
Merged

TST: move misplaced tests #55603

merged 6 commits into from
Oct 20, 2023

Conversation

jbrockmendel
Copy link
Member

Also split some tests

Copy link
Member

@WillAyd WillAyd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm - nice work

@@ -40,17 +39,3 @@ def test_factorize(self):
arr, idx = idx2.factorize()
tm.assert_numpy_array_equal(arr, exp_arr)
tm.assert_index_equal(idx, exp_idx)

def test_factorize_complex(self): # TODO: WTF is this test doing here?s
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Interesting original placement

@mroeschke mroeschke added this to the 2.2 milestone Oct 20, 2023
@mroeschke mroeschke added the Testing pandas testing functions or related to the test suite label Oct 20, 2023
@mroeschke mroeschke merged commit 52cdc34 into pandas-dev:main Oct 20, 2023
37 checks passed
@mroeschke
Copy link
Member

Thanks @jbrockmendel

@jbrockmendel jbrockmendel deleted the ref-tsts branch October 20, 2023 18:32
smarie pushed a commit to smarie/pandas that referenced this pull request Nov 11, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Testing pandas testing functions or related to the test suite
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants