Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update get_utc declarations #55507

Merged
merged 2 commits into from
Oct 13, 2023
Merged

Conversation

WillAyd
Copy link
Member

@WillAyd WillAyd commented Oct 13, 2023

This helps a bit with the Cython 3.0 performance; the regression here is that without noexcept Cython checks for an error each invocation of bisect_right_i8

The const qualifiers are not necessarily required, but are a nice safety add-on and only give the compiler a better chance to optimize

@WillAyd WillAyd requested a review from MarcoGorelli as a code owner October 13, 2023 14:09
@jbrockmendel
Copy link
Member

LGTM pending green

@mroeschke mroeschke added Internals Related to non-user accessible pandas implementation Timezones Timezone data dtype labels Oct 13, 2023
@mroeschke mroeschke added this to the 2.2 milestone Oct 13, 2023
@mroeschke mroeschke merged commit c1d3604 into pandas-dev:main Oct 13, 2023
39 of 41 checks passed
@mroeschke
Copy link
Member

Thanks @WillAyd

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Internals Related to non-user accessible pandas implementation Timezones Timezone data dtype
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants