Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: DataFrame.to_json OverflowError with np.long* dtypes #55495

Merged
merged 3 commits into from
Oct 16, 2023
Merged

BUG: DataFrame.to_json OverflowError with np.long* dtypes #55495

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
3e3c713
BUG: DataFrame.to_json OverflowError with np.long* dtypes
gupta-paras Oct 12, 2023
7a29022
BUG: DataFrame.to_json OverflowError with np.long* dtypes #Comment-1
gupta-paras Oct 13, 2023
774519f
BUG: DataFrame.to_json OverflowError with np.long* dtypes #Comment-2
gupta-paras Oct 14, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions doc/source/whatsnew/v2.2.0.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -348,6 +348,7 @@ I/O
- Bug in :func:`read_csv` with ``engine="pyarrow"`` where ``usecols`` wasn't working with a csv with no headers (:issue:`54459`)
- Bug in :func:`read_excel`, with ``engine="xlrd"`` (``xls`` files) erroring when file contains NaNs/Infs (:issue:`54564`)
- Bug in :func:`to_excel`, with ``OdsWriter`` (``ods`` files) writing boolean/string value (:issue:`54994`)
- Bug in :meth:`DataFrame.to_json` OverflowError with np.long* dtypes (:issue:`55403`)
gupta-paras marked this conversation as resolved.
Show resolved Hide resolved
- Bug in :meth:`pandas.read_excel` with an ODS file without cached formatted cell for float values (:issue:`55219`)

Period
Expand Down
8 changes: 6 additions & 2 deletions pandas/_libs/src/vendored/ujson/python/objToJSON.c
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1610,9 +1610,13 @@ void Object_beginTypeContext(JSOBJ _obj, JSONTypeContext *tc) {
PyArray_DescrFromType(NPY_DOUBLE));
tc->type = JT_DOUBLE;
return;
} else if (PyArray_Check(obj) && PyArray_CheckScalar(obj)) {
} else if (PyArray_CheckScalar(obj)) {
/* This handles all cases of array of zero dimension (numpy.array(1)) OR
gupta-paras marked this conversation as resolved.
Show resolved Hide resolved
unimplemented serializable for numpy scalar type like: numpy.longdouble.
If we plan to handle any other numpy type for serializations,
we need to keep it above this block. */
PyErr_Format(PyExc_TypeError,
"%R (0d array) is not JSON serializable at the moment",
"%R (numpy-scalar) is not JSON serializable at the moment",
obj);
goto INVALID;
} else if (object_is_na_type(obj)) {
Expand Down
11 changes: 10 additions & 1 deletion pandas/tests/io/json/test_ujson.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -814,10 +814,19 @@ def test_array_float(self):

def test_0d_array(self):
# gh-18878
msg = re.escape("array(1) (0d array) is not JSON serializable at the moment")
msg = re.escape(
"array(1) (numpy-scalar) is not JSON serializable at the moment"
)
with pytest.raises(TypeError, match=msg):
ujson.ujson_dumps(np.array(1))

def test_array_long_double(self):
msg = re.compile(
"1234.5.* \\(numpy-scalar\\) is not JSON serializable at the moment"
)
with pytest.raises(TypeError, match=msg):
ujson.ujson_dumps(np.longdouble(1234.5))


class TestPandasJSONTests:
def test_dataframe(self, orient):
Expand Down
Loading