DEPR: Previous implementation of DataFrame.stack #55448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rhshadrach
added
Reshaping
mroeschke
reviewed
Oct 16, 2023
| @@ -249,6 +249,9 @@ def test_merge_on_extension_array_duplicates(self, data): | |||
| ) | |||
| tm.assert_frame_equal(result, expected) | |||
|
|
|||
| @pytest.mark.filterwarnings( | |||
| "ignore:The previous implementation of stack is deprecated" | |||
There was a problem hiding this comment.
Just for my edification, when this deprecation is enforced will we need to change all/most of these unit tests?
There was a problem hiding this comment.
Correct - but all tests that use stack test with both future_stack=False and future_stack=True. So it will just be ripping out the future_stack=False case.
mroeschke
approved these changes
Oct 17, 2023
|
Thanks @rhshadrach |
This was referenced Oct 26, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.