TYP: Add overload for ser.rename_axis #55412
Conversation
|
pre-commit.ci autofix |
caneff
changed the title
caneff
force-pushed
the
overload_rename_axis
branch
from
338a2ad to
697b4e8
Compare
caneff
force-pushed
the
overload_rename_axis
branch
from
697b4e8 to
482c006
Compare
|
pre-commit.ci autofix |
caneff
force-pushed
the
overload_rename_axis
branch
from
3de1e1c to
540d5e2
Compare
|
pre-commit.ci autofix |
pandas/core/series.py
Outdated
| @@ -5004,6 +5004,42 @@ def reindex( # type: ignore[override] | |||
| tolerance=tolerance, | |||
| ) | |||
|
|
|||
| @overload | |||
There was a problem hiding this comment.
It seems that the error codes are misaligned, see mypy:
pandas/core/series.py:5007: error: Signature of "rename_axis" incompatible with supertype "NDFrame" [override]
[...]
pandas/core/series.py:5008: error: Unused "type: ignore" comment [unused-ignore]
pandas/core/series.py:5020: error: Unused "type: ignore" comment [unused-ignore]
pandas/core/series.py:5032: error: Unused "type: ignore" comment [unused-ignore]
pandas/core/series.py:5044: error: Unused "type: ignore" comment [unused-ignore]
There was a problem hiding this comment.
you might want to run mypy (and black) locally :)
pandas/core/series.py:5007: error: Signature of "rename_axis" incompatible with supertype "NDFrame" [override]
There was a problem hiding this comment.
Sorry, went and got my precommit setup fixed now and will run locally.
What is the actual issue? Without the ignore it complains about incompatible signatures, and adding the ignore it just says the ignore is unused. So what is the right fix? I see they are incompatible because ser.rename_axis takes less arguments but I don't know what to do about it
There was a problem hiding this comment.
Mpyps seems to expect the ignore only on specific lines (5007), not all of them.
There was a problem hiding this comment.
OK understood. Now it seems to be not complaining.
caneff
force-pushed
the
overload_rename_axis
branch
2 times, most recently
from
0655a12 to
ffbc32d
Compare
for more information, see https://pre-commit.ci
caneff
force-pushed
the
overload_rename_axis
branch
from
ffbc32d to
a608be6
Compare
|
Thank you @caneff ! |
Another overload that improves typing when not using stubs.