Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MAINT: Add warning filter for np.long #55397

Merged
merged 1 commit into from
Oct 4, 2023

Conversation

mtsokol
Copy link
Contributor

@mtsokol mtsokol commented Oct 4, 2023

Hi!
This is a one-line follow-up PR after #55369.
Downstream libs that use nightly pandas and numpy will see a warning without it (there was a similar fix for scipy: scipy/scipy#19341).

@pllim
Copy link

pllim commented Oct 4, 2023

Hello (again) and thanks for this PR. I am seeing the warning but this time from pandas instead of scipy.

np_long = np.long # type: ignore[attr-defined]

Example log: https://github.com/spacetelescope/jdaviz/actions/runs/6407816486/job/17396675526?pr=2492

@mroeschke mroeschke added the Compat pandas objects compatability with Numpy or Python functions label Oct 4, 2023
@mroeschke mroeschke added this to the 2.1.2 milestone Oct 4, 2023
@mroeschke mroeschke merged commit eb6317a into pandas-dev:main Oct 4, 2023
37 checks passed
@mroeschke
Copy link
Member

Great thanks @mtsokol

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 4, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 eb6317a3cf45dfeb76f81655310604de029ad596
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55397: MAINT: Add warning filter for `np.long`'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55397-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55397 on branch 2.1.x (MAINT: Add warning filter for np.long)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mtsokol mtsokol deleted the include-warn-filter-for-np-long branch October 4, 2023 16:45
@mroeschke
Copy link
Member

@meeseeksdev backport 2.1.x

meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Oct 4, 2023
mroeschke pushed a commit that referenced this pull request Oct 4, 2023
….long`) (#55402)

Backport PR #55397: MAINT: Add warning filter for `np.long`

Co-authored-by: Mateusz Sokół <[email protected]>
mtsokol added a commit to mtsokol/pandas that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Compat pandas objects compatability with Numpy or Python functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants