BUG: eq not implemented for categorical and arrow backed strings #55364
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mroeschke
reviewed
Oct 3, 2023
| if isinstance(other, (ArrowExtensionArray, np.ndarray, list, BaseMaskedArray)): | ||
| if isinstance( | ||
| other, (ArrowExtensionArray, np.ndarray, list, BaseMaskedArray) | ||
| ) or isinstance(getattr(other, "dtype", None), CategoricalDtype): |
There was a problem hiding this comment.
So for Categorical, we don't need to extract the underlying values?
There was a problem hiding this comment.
That's what _box_pa is doing, isn't it?
There was a problem hiding this comment.
True, I guess in _box_pa pa.array is correctly handling it luckily which is good.
mroeschke
added
Strings
mroeschke
approved these changes
Oct 3, 2023
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Oct 3, 2023
… and arrow backed strings
mroeschke
pushed a commit
that referenced
this pull request
Oct 3, 2023
…orical and arrow backed strings) (#55381) Backport PR #55364: BUG: eq not implemented for categorical and arrow backed strings Co-authored-by: Patrick Hoefler <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.