-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEPR: create_block_manager_from_blocks #55355
Conversation
Are you aware of any libraries using this? |
@phofl says dask is using it |
Yep, I’d prefer not to deprecate |
im pretty set on this; we need to ween dask and anyone else off of internals in general if we want to be able to change anything. in particular i want to get the axes out of the Managers |
We are serializing/de-serializing the blocks. I am open to do this differently though, but not sure if there is an efficient way of doing this |
Create a DataFrame for each block and concat them? |
Can we offer a private api for this maybe? List of blocks and axes? |
After this PR dask can get continue to import the function from internals.api which is explicitly pseudo-public for pyarrow/dask. This PR is just getting the function to the more-correct place. Long-term, no. dask and anyone else need to stop using Blocks/Managers directly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm
No description provided.