TYP: read_csv's usecols #55330
Merged
TYP: read_csv's usecols #55330
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
twoertwein
commented
Sep 30, 2023
Dr-Irv
approved these changes
Oct 4, 2023
There was a problem hiding this comment.
thanks @twoertwein . There are still slight differences between pandas-stubs and pandas here. Do you want to create an issue or PR for the stubs to align things?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This makes read_csv's usecols compatible with the tests from pandas-stubs.
The documentation does mention only list, Callable, and None! This notably excludes range, tuple, and ndarray. I'm happy to tighten the types to the documented types or adjust the documentation.
edit: The pandas tests cover list, tuple, set, nd.array and probably more -> I adjusted the documentation