Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pyproject.toml - replace output_formatting with output-formatting #55275

Merged
merged 6 commits into from
Sep 26, 2023
Merged

Update pyproject.toml - replace output_formatting with output-formatting #55275

merged 6 commits into from
Sep 26, 2023

Conversation

barseghyanartur
Copy link
Contributor

@barseghyanartur barseghyanartur commented Sep 25, 2023 •
edited by mroeschke
Loading

closes #55290

Simply said, none of this would work (dependencies from output-formatting would not be installed):

pip install pandas[output-formatting]
pip install pandas[output_formatting]
pip install pandas[output-formatting,xml]

When being distributed, underscores are replaces with dashes. So, in the packaged PKG-INFO file you won't find spots of output_formatting, but only output-formatting:

Requires-Dist: lxml>=4.8.0; extra == "xml"
Requires-Dist: jinja2>=3.1.2; extra == "output-formatting"
Requires-Dist: tabulate>=0.8.10; extra == "output-formatting"

But on the same time, this:

Provides-Extra: output_formatting

This fix addresses that.

@mroeschke
Copy link
Member

Thanks could you add a whatsnew note in 2.1.2.rst?

@mroeschke mroeschke added the Build Library building on various platforms label Sep 25, 2023
@barseghyanartur
Copy link
Contributor Author

@mroeschke:

Done.

@mroeschke
Copy link
Member

Could you also change the references in doc/source/getting_started/install.rst and .github/workflows/package-checks.yml?

@barseghyanartur
Copy link
Contributor Author

@mroeschke:

Done.

@mroeschke mroeschke added this to the 2.1.2 milestone Sep 26, 2023
@mroeschke mroeschke merged commit 89bd569 into pandas-dev:main Sep 26, 2023
71 checks passed
@mroeschke
Copy link
Member

Thanks @barseghyanartur

@meeseeksmachine meeseeksmachine mentioned this pull request Sep 26, 2023
Merged
meeseeksmachine pushed a commit to meeseeksmachine/pandas that referenced this pull request Sep 26, 2023
@barseghyanartur @meeseeksmachine
Backport PR pandas-dev#55275: Update pyproject.toml - replace `output…
e2d51d5 
…_formatting` with `output-formatting`
mroeschke pushed a commit that referenced this pull request Sep 26, 2023
@meeseeksmachine @barseghyanartur
Backport PR #55275 on branch 2.1.x (Update pyproject.toml - replace `…
eec2023 
…output_formatting` with `output-formatting`) (#55291)

Backport PR #55275: Update pyproject.toml - replace `output_formatting` with `output-formatting`

Co-authored-by: Artur Barseghyan <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

Assignees
No one assigned
Labels
Build Library building on various platforms
Projects
None yet
Milestone
2.1.2
Development

Successfully merging this pull request may close these issues.

BUILD: pandas[output_formatting] doesn't install optional dependencies
2 participants
@barseghyanartur @mroeschke