TYP: Misc changes for pandas-stubs; use Protocol to avoid str in Sequence #55263
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Dr-Irv
approved these changes
Sep 26, 2023
mroeschke
approved these changes
Sep 26, 2023
|
Thanks @twoertwein (you two are the typing authorities as far as I'm concerned :) ) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The first commit addresses some type issues found by running mypy on the tests from pandas-stubs (one big issue is that Index/Series are not included in IndexLabel; there might be cases where that is correct but in many cases they should be included).
The second commit re-writes #47233 with the protocol version of Sequence.
Can split it in two PRs if one of them is controversial.