DOC: correct an example in v0.14.0.rst to fix "NameError" #55182
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@rhshadrach, could you please take a look at this PR? |
rhshadrach
approved these changes
Sep 18, 2023
There was a problem hiding this comment.
lgtm; I'm not seeing this fail on any recent PRs, so not sure why you're seeing this error. g is defined in an .. ipython:: python block above.
Still, without this the docs have the wrong output because of the change to a .. code-block:: immediately above - so nice find!
|
Thanks @natmokval |
|
Thanks @rhshadrach for reviewing this PR. |
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
while building whatsnew/v0.14.0.rst the error occurs:
corrected the example to fix the error.