Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Silence Period[B] warnings in plotting code #55138

Merged
merged 3 commits into from
Oct 3, 2023

Conversation

torext
Copy link
Contributor

@torext torext commented Sep 14, 2023

This silences warnings introduced by #53446 that would happen during normal plotting activity.

@torext torext mentioned this pull request Sep 14, 2023
3 tasks
@torext torext force-pushed the fix-period-warnings branch 2 times, most recently from eabcc97 to 71412ff Compare September 21, 2023 12:58
@torext
Copy link
Contributor Author

torext commented Sep 21, 2023

Anything else I can do here to get this merged?

@torext torext force-pushed the fix-period-warnings branch from bc1a440 to 0d214d4 Compare October 2, 2023 08:15
@torext torext force-pushed the fix-period-warnings branch from 0d214d4 to c7eb6cf Compare October 2, 2023 13:41
Copy link
Member

@mroeschke mroeschke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks. Could you add a whatsnew note to 2.1.2.rst?

@torext
Copy link
Contributor Author

torext commented Oct 3, 2023

Thanks. Could you add a whatsnew note to 2.1.2.rst?

Sure thing, @mroeschke, that's done now. Admittedly not completely sure I respected the style of both the entry and the corresponding commit message correctly, apologies in advance if it's not the case!

@mroeschke mroeschke added Visualization plotting Frequency DateOffsets Warnings Warnings that appear or should be added to pandas labels Oct 3, 2023
@mroeschke mroeschke added this to the 2.1.2 milestone Oct 3, 2023
@mroeschke mroeschke merged commit 6e6a683 into pandas-dev:main Oct 3, 2023
42 of 43 checks passed
@mroeschke
Copy link
Member

Thanks @torext

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 3, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6e6a6831aaa2d1606aa897b34f106e655180034b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55138: BUG: Silence `Period[B]` warnings in plotting code'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55138-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55138 on branch 2.1.x (BUG: Silence Period[B] warnings in plotting code)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

@mroeschke
Copy link
Member

@meeseeksdev backport 2.1.x

@lumberbot-app
Copy link

lumberbot-app bot commented Oct 3, 2023

Owee, I'm MrMeeseeks, Look at me.

There seem to be a conflict, please backport manually. Here are approximate instructions:

  1. Checkout backport branch and update it.
git checkout 2.1.x
git pull
  1. Cherry pick the first parent branch of the this PR on top of the older branch:
git cherry-pick -x -m1 6e6a6831aaa2d1606aa897b34f106e655180034b
  1. You will likely have some merge/cherry-pick conflict here, fix them and commit:
git commit -am 'Backport PR #55138: BUG: Silence `Period[B]` warnings in plotting code'
  1. Push to a named branch:
git push YOURFORK 2.1.x:auto-backport-of-pr-55138-on-2.1.x
  1. Create a PR against branch 2.1.x, I would have named this PR:

"Backport PR #55138 on branch 2.1.x (BUG: Silence Period[B] warnings in plotting code)"

And apply the correct labels and milestones.

Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon!

Remember to remove the Still Needs Manual Backport label once the PR gets merged.

If these instructions are inaccurate, feel free to suggest an improvement.

mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Oct 3, 2023
mroeschke added a commit that referenced this pull request Oct 4, 2023
#55378)

* Backport PR #55138: BUG: Silence `Period[B]` warnings in plotting code

* Don't build in parallel to see error

* Remove period call

* Another suppress?

---------

Co-authored-by: torext <[email protected]>
@torext torext deleted the fix-period-warnings branch October 4, 2023 07:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Frequency DateOffsets Visualization plotting Warnings Warnings that appear or should be added to pandas
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants