-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Silence Period[B]
warnings in plotting code
#55138
Conversation
eabcc97
to
71412ff
Compare
Anything else I can do here to get this merged? |
858a12a
to
bc1a440
Compare
bc1a440
to
0d214d4
Compare
0d214d4
to
c7eb6cf
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks. Could you add a whatsnew note to 2.1.2.rst
?
Sure thing, @mroeschke, that's done now. Admittedly not completely sure I respected the style of both the entry and the corresponding commit message correctly, apologies in advance if it's not the case! |
Thanks @torext |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
@meeseeksdev backport 2.1.x |
Owee, I'm MrMeeseeks, Look at me. There seem to be a conflict, please backport manually. Here are approximate instructions:
And apply the correct labels and milestones. Congratulations — you did some good work! Hopefully your backport PR will be tested by the continuous integration and merged soon! Remember to remove the If these instructions are inaccurate, feel free to suggest an improvement. |
#55378) * Backport PR #55138: BUG: Silence `Period[B]` warnings in plotting code * Don't build in parallel to see error * Remove period call * Another suppress? --------- Co-authored-by: torext <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.This silences warnings introduced by #53446 that would happen during normal plotting activity.