-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
BUG: Index.difference not always returning a unique set of values #55113
Merged
mroeschke
merged 5 commits into
pandas-dev:main
from
lukemanley:bug-index-difference-unique
Sep 18, 2023
Merged
BUG: Index.difference not always returning a unique set of values #55113
mroeschke
merged 5 commits into
pandas-dev:main
from
lukemanley:bug-index-difference-unique
Sep 18, 2023
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukemanley
added
Bug
setops
union, intersection, difference, symmetric_difference
labels
Sep 12, 2023
mroeschke
reviewed
Sep 13, 2023
pandas/tests/indexes/test_setops.py
Outdated
@@ -799,8 +799,16 @@ def test_difference_empty_arg(self, index, sort): | |||
first = index[5:20] | |||
first.name = "name" | |||
result = first.difference([], sort) | |||
expected = first.unique() |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could you construct a completely new Index
for `expected instead (and below)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Updated
mroeschke
approved these changes
Sep 18, 2023
Thanks @lukemanley |
hedeershowk
pushed a commit
to hedeershowk/pandas
that referenced
this pull request
Sep 20, 2023
…ndas-dev#55113) * BUG: Index.difference not always returning a unique set of values * whatsnew * udpate test * update test
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/v2.2.0.rst
file if fixing a bug or adding a new feature.Index.difference
has two short-circuit paths which currently differ in behavior from the main path in that they do not return a unique set of values when duplicates exist: