Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG fix for str.startswith and str.endswith with tuple arg for "string[pyarrow]" dtype (GH#54942) #54943

Merged

Conversation

ChronoJon
Copy link
Contributor

@ChronoJon ChronoJon commented Sep 1, 2023

@ChronoJon ChronoJon changed the title Fix pyarrow str start ends with tuple BUG fix for str.startswith and str.endswith with tuple arg for "string[pyarrow]" dtype (GH#54942) Sep 1, 2023
@ChronoJon
Copy link
Contributor Author

I will probably have time to fix this tonight.

@ChronoJon ChronoJon force-pushed the fix-pyarrow-str-start-ends-with-tuple branch 2 times, most recently from 168a14a to c72c070 Compare September 6, 2023 08:16
@github-actions
Copy link
Contributor

github-actions bot commented Oct 7, 2023

This pull request is stale because it has been open for thirty days with no activity. Please update and respond to this comment if you're still interested in working on this.

@github-actions github-actions bot added the Stale label Oct 7, 2023
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

pandas/core/arrays/string_arrow.py Outdated Show resolved Hide resolved
pandas/core/arrays/string_arrow.py Outdated Show resolved Hide resolved
doc/source/whatsnew/v2.2.0.rst Outdated Show resolved Hide resolved
@rhshadrach rhshadrach added Bug Strings String extension data type and string data and removed Stale labels Oct 7, 2023
Copy link
Member

@rhshadrach rhshadrach left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@ChronoJon ChronoJon force-pushed the fix-pyarrow-str-start-ends-with-tuple branch from 6da7131 to fbdedaa Compare October 10, 2023 21:13
@mroeschke mroeschke added this to the 2.2 milestone Oct 23, 2023
@mroeschke mroeschke merged commit 2b6af64 into pandas-dev:main Oct 23, 2023
33 checks passed
@mroeschke
Copy link
Member

Thanks @ChronoJon

@ChronoJon ChronoJon deleted the fix-pyarrow-str-start-ends-with-tuple branch October 24, 2023 08:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Strings String extension data type and string data
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: str.startswith and str.endswith with tuple argument fail for "string[pyarrow]"
4 participants