Use NaN as na_value for new pyarrow_numpy StringDtype #54585
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…semantics # Conflicts: # pandas/core/arrays/_arrow_string_mixins.py # pandas/tests/strings/__init__.py # pandas/tests/strings/test_strings.py
…semantics_2 # Conflicts: # pandas/tests/strings/test_find_replace.py
…to string_array_numpy_semantics
This was referenced Aug 16, 2023
|
Looking just at the single commit d862eca, that looks good to me |
…semantics_na_val # Conflicts: # pandas/tests/arrays/string_/test_string.py # pandas/tests/extension/test_string.py
…semantics_na_val # Conflicts: # pandas/tests/strings/__init__.py # pandas/tests/strings/test_split_partition.py
…semantics_na_val # Conflicts: # pandas/core/arrays/string_arrow.py # pandas/tests/arrays/string_/test_string.py # pandas/tests/strings/test_case_justify.py
|
rebased, the diff is more manageable now |
jorisvandenbossche
approved these changes
Aug 24, 2023
jorisvandenbossche
changed the title
|
merging this |
|
@meeseeksdev backport to 2.1.x |
meeseeksmachine
pushed a commit
to meeseeksmachine/pandas
that referenced
this pull request
Aug 26, 2023
phofl
added a commit
that referenced
this pull request
Aug 26, 2023
…ow_numpy StringDtype) (#54767) Backport PR #54585: Use NaN as na_value for new pyarrow_numpy StringDtype Co-authored-by: Patrick Hoefler <[email protected]>
41 tasks
mroeschke
pushed a commit
to mroeschke/pandas
that referenced
this pull request
Sep 11, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
doc/source/whatsnew/vX.X.X.rstfile if fixing a bug or adding a new feature.xref #54792