Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CLN: Cython 3 cleanups #54482

Merged
merged 3 commits into from
Aug 10, 2023
Merged

CLN: Cython 3 cleanups #54482

merged 3 commits into from
Aug 10, 2023

Conversation

lithomas1
Copy link
Member

  • closes #xxxx (Replace xxxx with the GitHub issue number)
  • Tests added and passed if fixing a bug or adding a new feature
  • All code checks passed.
  • Added type annotations to new arguments/methods/functions.
  • Added an entry in the latest doc/source/whatsnew/vX.X.X.rst file if fixing a bug or adding a new feature.

This doesn't get all of #34213, but it gets us 90% of the way there.

@lithomas1 lithomas1 added this to the 2.1 milestone Aug 10, 2023
@mroeschke mroeschke merged commit a936863 into pandas-dev:main Aug 10, 2023
@mroeschke
Copy link
Member

Nice thanks @lithomas1

phofl added a commit to phofl/pandas that referenced this pull request Aug 11, 2023
@phofl
Revert "CLN: Cython 3 cleanups (pandas-dev#54482)"
f702b77 
This reverts commit a936863.
lithomas1 pushed a commit that referenced this pull request Aug 11, 2023
@phofl
Revert Cython upgrade (#54497)
3edb82b 
* Revert "CLN: Cython 3 cleanups (#54482)"

This reverts commit a936863.

* Revert "DEPS: Bump cython 3.0 (#54335)"

This reverts commit 4cf63ea.
@lithomas1 lithomas1 deleted the cln-cython-3 branch August 18, 2023 07:29
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
@lithomas1 @mroeschke
CLN: Cython 3 cleanups (pandas-dev#54482)
370f329 
* CLN: Update code for Cython 3

* clean more

* fix tests
mroeschke pushed a commit to mroeschke/pandas that referenced this pull request Aug 18, 2023
@phofl @mroeschke
Revert Cython upgrade (pandas-dev#54497)
d51bff1 
* Revert "CLN: Cython 3 cleanups (pandas-dev#54482)"

This reverts commit a936863.

* Revert "DEPS: Bump cython 3.0 (pandas-dev#54335)"

This reverts commit 4cf63ea.
@lithomas1 lithomas1 mentioned this pull request Dec 4, 2023
Open
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mroeschke mroeschke mroeschke approved these changes

@MarcoGorelli MarcoGorelli Awaiting requested review from MarcoGorelli MarcoGorelli is a code owner

@WillAyd WillAyd Awaiting requested review from WillAyd WillAyd is a code owner

Assignees
No one assigned
Labels
Clean
Projects
None yet
Milestone
2.1
Development

Successfully merging this pull request may close these issues.
2 participants
@lithomas1 @mroeschke