-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Modified doc/make.py to run sphinx-build -b linkcheck #54265
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modifying doc/make.py to run sphinx-build -b linkcheck.
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
The pre-commit.ci-pr is passed. What should be the next step ? |
Please do not rush to step 4. before the others are completely done. |
Hi @mroeschke , could you please have a look at this PR ? |
Can you show the output of running this locally? |
Co-authored-by: Matthew Roeschke <[email protected]>
@mroeschke , I couldn't complete the whole output as this is taking too much time, so I interrupted the output. gitpod@pandasdev-pandas-htsoniz5w57:/workspace/pandas/doc$ python make.py linkcheck
(reference/api/pandas.DataFrame.style: line 28) ok ../../user_guide/style.ipynb |
@mroeschke , I have upadated your suggestion and pasted the output. |
pre-commit.ci autofix |
for more information, see https://pre-commit.ci
@mroeschke , I have upadated your suggestion. |
Seems like the changes are failing the doc build |
@mroeschke , I can't figure out why it's failing ? Can you please help me on this ? |
@pmeier , any suggestions ? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@ggold7046 To be frank: I get the impression that you don't understand what you are implementing here. If that is true, it is also futile to try to debug CI.
I'm going to flag a few lines below and you should understand them first before doing anything else. If you want my help with that, add an explanation in your own words what you think it does.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looking pretty good after https://github.com/pandas-dev/pandas/pull/54265/files#r1329224318. Some inline nits.
Co-authored-by: Philip Meier <[email protected]>
Co-authored-by: Philip Meier <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM for the functionality. Thanks for pulling through @ggold7046! Could you close all resolved conversations and act on the points in #54265 (comment)?
Thank you @pmeier for guiding me through this PR.
You mean on rest of this issue ? #45409 (comment) |
No. Check the applicable boxes and perform the action if necessary. |
@pmeier , after this pr is closed should I go ahead with the rest of the issue ? |
SGTM. My next step would be to actually run |
As @pmeier mentioned, could you open a new Github issue detailing the output of |
@mroeschke , there is an output I ran in this link #54265 (comment), though I couldn't complete because it was taking too much time. So I interrupted. There are many broken links and client error found in that detail. |
Thanks for sticking with this @ggold7046. Okay if you could just create a follow up PR(s) tackling some of the link fixes in batches that would be great then. |
* Modified doc/make.py to run sphinx-build -b linkcheck * Update make.py * Update make.py * Update make.py * Update make.py * Update make.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update doc/make.py Co-authored-by: Matthew Roeschke <[email protected]> * Update make.py * [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci * Update make.py * Update doc/make.py Co-authored-by: Philip Meier <[email protected]> * Update doc/make.py Co-authored-by: Philip Meier <[email protected]> * Update make.py --------- Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Matthew Roeschke <[email protected]> Co-authored-by: Philip Meier <[email protected]>
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.