-
-
Notifications
You must be signed in to change notification settings - Fork 18.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC: Update merge copy parameter code and doc #54077
Conversation
pandas/core/frame.py
Outdated
@@ -356,7 +356,8 @@ | |||
`right` should be left as-is, with no suffix. At least one of the | |||
values must not be None. | |||
copy : bool, default True | |||
If False, avoid copy if possible. | |||
If False, avoid copy if copy requirements are fulfilled. If copy operation |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Not sure if this description clarifies when a copy is needed
8ec298f
to
729ef89
Compare
I have checked merge copy related codes, found that following codes will decide if copy:
The needs_copy parameter is defined by user input, CoW status and concat axis.The indexers parameter is defined by following codes:
I don't know why new_labels can be not equal to obj_labels. They are both from objs, although there are some operations in self.new_axes function. I have tried several examples, but can't get an indexers value which is not None. |
1b1dc15
to
8fedf55
Compare
Signed-off-by: Liang Yan <[email protected]>
Signed-off-by: Liang Yan <[email protected]>
Thanks for the pull request, but it appears to have gone stale. If interested in continuing, please merge in the main branch, address any review comments and/or failing tests, and we can reopen. |
doc/source/whatsnew/vX.X.X.rst
file if fixing a bug or adding a new feature.