Skip to content

Commit

Permalink
TST: clean CoW chained assignment warning iloc test case
Browse files Browse the repository at this point in the history
  • Loading branch information
jorisvandenbossche committed Dec 8, 2023
1 parent 8399185 commit ff5ca2d
Showing 1 changed file with 14 additions and 12 deletions.
26 changes: 14 additions & 12 deletions pandas/tests/copy_view/test_chained_assignment_deprecation.py
Original file line number Diff line number Diff line change
Expand Up @@ -35,36 +35,38 @@ def test_methods_iloc_warn(using_copy_on_write):
@pytest.mark.parametrize(
"func, args",
[
("replace", (1, 5)),
("replace", (4, 5)),
("fillna", (1,)),
("interpolate", ()),
("bfill", ()),
("ffill", ()),
],
)
def test_methods_iloc_getitem_item_cache(
func, args, using_copy_on_write, warn_copy_on_write
):
df = DataFrame({"a": [1, 2, 3], "b": 1})
def test_methods_iloc_getitem_item_cache(func, args, using_copy_on_write):
# ensure we don't incorrectly raise chained assignment warning because
# of the item cache / iloc not setting the item cache
df_orig = DataFrame({"a": [1, 2, 3], "b": 1})

df = df_orig.copy()
ser = df.iloc[:, 0]
with tm.assert_cow_warning(warn_copy_on_write and func == "replace"):
getattr(ser, func)(*args, inplace=True)
getattr(ser, func)(*args, inplace=True)

# parent that holds item_cache is dead, so don't increase ref count
df = df_orig.copy()
ser = df.copy()["a"]
getattr(ser, func)(*args, inplace=True)

df = df.copy()

df = df_orig.copy()
df["a"] # populate the item_cache
ser = df.iloc[:, 0] # iloc creates a new object
ser.fillna(0, inplace=True)
getattr(ser, func)(*args, inplace=True)

df = df_orig.copy()
df["a"] # populate the item_cache
ser = df["a"]
ser.fillna(0, inplace=True)
getattr(ser, func)(*args, inplace=True)

df = df.copy()
df = df_orig.copy()
df["a"] # populate the item_cache
if using_copy_on_write:
with tm.raises_chained_assignment_error():
Expand Down

0 comments on commit ff5ca2d

Please sign in to comment.