Skip to content

Commit

Permalink
Add more xfails
Browse files Browse the repository at this point in the history
  • Loading branch information
mroeschke committed Dec 17, 2024
1 parent 10cd782 commit e6ab121
Show file tree
Hide file tree
Showing 2 changed files with 20 additions and 2 deletions.
13 changes: 12 additions & 1 deletion pandas/tests/plotting/frame/test_frame.py
Original file line number Diff line number Diff line change
Expand Up @@ -1071,6 +1071,10 @@ def test_boxplot_series_positions(self, hist_df):
assert len(ax.lines) == 7 * len(numeric_cols)

@pytest.mark.filterwarnings("ignore:set_ticklabels:UserWarning")
@pytest.mark.xfail(
Version(mpl.__version__) >= Version("3.10"),
reason="Fails starting with matplotlib 3.10",
)
def test_boxplot_vertical(self, hist_df):
df = hist_df
numeric_cols = df._get_numeric_data().columns
Expand All @@ -1088,7 +1092,10 @@ def test_boxplot_vertical(self, hist_df):
assert len(ax.lines) == 7 * len(numeric_cols)

@pytest.mark.filterwarnings("ignore::UserWarning")
@pytest.mark.xfail(Version(mpl.__version__) > Version("3.10"), reason="TODO")
@pytest.mark.xfail(
Version(mpl.__version__) >= Version("3.10"),
reason="Fails starting with matplotlib version 3.10",
)
def test_boxplot_vertical_subplots(self, hist_df):
df = hist_df
numeric_cols = df._get_numeric_data().columns
Expand All @@ -1108,6 +1115,10 @@ def test_boxplot_vertical_subplots(self, hist_df):
assert len(ax.lines) == 7

@pytest.mark.filterwarnings("ignore:set_ticklabels:UserWarning")
@pytest.mark.xfail(
Version(mpl.__version__) >= Version("3.10"),
reason="Fails starting with matplotlib 3.10",
)
def test_boxplot_vertical_positions(self, hist_df):
df = hist_df
numeric_cols = df._get_numeric_data().columns
Expand Down
9 changes: 8 additions & 1 deletion pandas/tests/plotting/test_boxplot_method.py
Original file line number Diff line number Diff line change
Expand Up @@ -355,6 +355,7 @@ def test_plot_box(self, vert):
assert ax.get_xlabel() == xlabel
assert ax.get_ylabel() == ylabel

@pytest.mark.filterwarnings("ignore:set_ticklabels:UserWarning")
def test_boxplot_xlabel_ylabel(self, vert):
df = DataFrame(
{
Expand Down Expand Up @@ -384,7 +385,13 @@ def test_boxplot_group_xlabel_ylabel(self, vert):
assert subplot.get_ylabel() == ylabel

@pytest.mark.filterwarnings("ignore:set_ticklabels:UserWarning")
def test_boxplot_group_no_xlabel_ylabel(self, vert):
def test_boxplot_group_no_xlabel_ylabel(self, vert, request):
if Version(mpl.__version__) >= Version("3.10") and vert == {
"orientation": "horizontal"
}:
request.applymarker(
pytest.mark.xfail(reason=f"{vert} fails starting with matplotlib 3.10")
)
df = DataFrame(
{
"a": np.random.default_rng(2).standard_normal(10),
Expand Down

0 comments on commit e6ab121

Please sign in to comment.