Skip to content

Commit

Permalink
TST (string dtype): avoid hardcoded object dtype for columns in datet…
Browse files Browse the repository at this point in the history
…ime_frame fixture (#60192)
  • Loading branch information
jorisvandenbossche authored Nov 5, 2024
1 parent eacf032 commit 34387bd
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 4 deletions.
2 changes: 1 addition & 1 deletion pandas/tests/frame/conftest.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ def datetime_frame() -> DataFrame:
"""
return DataFrame(
np.random.default_rng(2).standard_normal((10, 4)),
columns=Index(list("ABCD"), dtype=object),
columns=Index(list("ABCD")),
index=date_range("2000-01-01", periods=10, freq="B"),
)

Expand Down
1 change: 0 additions & 1 deletion pandas/tests/frame/indexing/test_indexing.py
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,6 @@ def test_getitem_boolean(self, mixed_float_frame, mixed_int_frame, datetime_fram
if bif[c].dtype != bifw[c].dtype:
assert bif[c].dtype == df[c].dtype

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
def test_getitem_boolean_casting(self, datetime_frame):
# don't upcast if we don't need to
df = datetime_frame.copy()
Expand Down
2 changes: 0 additions & 2 deletions pandas/tests/frame/methods/test_to_csv.py
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,6 @@ def test_to_csv_from_csv1(self, temp_file, float_frame):
float_frame.to_csv(path, header=False)
float_frame.to_csv(path, index=False)

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
def test_to_csv_from_csv1_datetime(self, temp_file, datetime_frame):
path = str(temp_file)
# test roundtrip
Expand Down Expand Up @@ -549,7 +548,6 @@ def test_to_csv_headers(self, temp_file):
assert return_value is None
tm.assert_frame_equal(to_df, recons)

@pytest.mark.xfail(using_string_dtype(), reason="TODO(infer_string)")
def test_to_csv_multiindex(self, temp_file, float_frame, datetime_frame):
frame = float_frame
old_index = frame.index
Expand Down

0 comments on commit 34387bd

Please sign in to comment.